Refactoring - Fix1

v2_adminpanel/routes/resource_routes.py

@@ -133,54 +133,55 @@ def resources():
 def add_resource():
     """Neue Ressource hinzufügen"""
     if request.method == 'POST':
-        conn = get_connection()
-        cur = conn.cursor()
-        
         try:
-            resource_type = request.form['resource_type']
-            resource_value = request.form['resource_value'].strip()
-            is_test = 'is_test' in request.form
-            
-            # Prüfe ob Ressource bereits existiert
-            cur.execute("""
-                SELECT id FROM resource_pools 
-                WHERE resource_type = %s AND resource_value = %s
-            """, (resource_type, resource_value))
-            
-            if cur.fetchone():
-                flash(f'Ressource {resource_value} existiert bereits!', 'error')
-                return redirect(url_for('resources.add_resource'))
-            
-            # Füge neue Ressource hinzu
-            cur.execute("""
-                INSERT INTO resource_pools (resource_type, resource_value, status, is_test, created_by)
-                VALUES (%s, %s, 'available', %s, %s)
-                RETURNING id
-            """, (resource_type, resource_value, is_test, session['username']))
-            
-            resource_id = cur.fetchone()[0]
-            conn.commit()
-            
-            # Audit-Log
-            log_audit('CREATE', 'resource', resource_id,
-                     new_values={
-                         'resource_type': resource_type,
-                         'resource_value': resource_value,
-                         'is_test': is_test
-                     })
-            
-            flash(f'Ressource {resource_value} erfolgreich hinzugefügt!', 'success')
-            return redirect(url_for('resources.resources'))
-            
+            with get_db_connection() as conn:
+                cur = conn.cursor()
+                try:
+                    resource_type = request.form['resource_type']
+                    resource_value = request.form['resource_value'].strip()
+                    is_test = 'is_test' in request.form
+                    
+                    # Prüfe ob Ressource bereits existiert
+                    cur.execute("""
+                        SELECT id FROM resource_pools 
+                        WHERE resource_type = %s AND resource_value = %s
+                    """, (resource_type, resource_value))
+                    
+                    if cur.fetchone():
+                        flash(f'Ressource {resource_value} existiert bereits!', 'error')
+                        return redirect(url_for('resources.add_resource'))
+                    
+                    # Füge neue Ressource hinzu (ohne created_by)
+                    cur.execute("""
+                        INSERT INTO resource_pools (resource_type, resource_value, status, is_test, status_changed_by)
+                        VALUES (%s, %s, 'available', %s, %s)
+                        RETURNING id
+                    """, (resource_type, resource_value, is_test, session.get('username', 'system')))
+                    
+                    resource_id = cur.fetchone()[0]
+                    conn.commit()
+                    
+                    # Audit-Log
+                    log_audit('CREATE', 'resource', resource_id,
+                             new_values={
+                                 'resource_type': resource_type,
+                                 'resource_value': resource_value,
+                                 'is_test': is_test
+                             })
+                    
+                    flash(f'Ressource {resource_value} erfolgreich hinzugefügt!', 'success')
+                    return redirect(url_for('resources.resources'))
+                finally:
+                    cur.close()
+                    
         except Exception as e:
-            conn.rollback()
+            import traceback
             logging.error(f"Fehler beim Hinzufügen der Ressource: {str(e)}")
-            flash('Fehler beim Hinzufügen der Ressource!', 'error')
-        finally:
-            cur.close()
-            conn.close()
+            logging.error(f"Traceback: {traceback.format_exc()}")
+            flash(f'Fehler: {str(e)}', 'error')
+            return redirect(url_for('resources.resources'))
     
-    return render_template('add_resource.html')
+    return render_template('add_resources.html')
 
 
 @resource_bp.route('/resources/quarantine/<int:resource_id>', methods=['POST'])